-
-
Notifications
You must be signed in to change notification settings - Fork 241
fix(dialogs): unable to show nested frameless modal views #1469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test branch_tns_core_modules#djenkov/proxy-view-container |
51bb4d5
to
4be8f16
Compare
test |
@ADjenkov Are we able now to use it via In other words - how can we test it ^ now ? |
Hi @RoyiNamir, |
@ADjenkov Thanks for reply. Question now is : should we only Basically we update a version via Will |
@RoyiNamir I'm not sure what your current deps are, but you can assure correct deps by automatically updating them with this. In your case just ingore the |
@ADjenkov Hi. - Update : Works, but it take a serious amount of time until the second modal opens. btw - this -
Was not sufficient , so I did this also ( like you said) 👍
Thank you. |
The problem: Unable to show modal from another modal if they are not presented from
<p-r-o>
(frameless). There is no availableviewController
(iOS) from whom we can present future modal view.The solution: Use previous modal child view as a
parentView
when presenting new modal. The child view a.k.a_ngDialogRoot
should have availableviewController
(iOS) created from the previous modal presentation.Fix: NativeScript/NativeScript#5924